From cf0185d110251046d588f354132b22e070786684 Mon Sep 17 00:00:00 2001 From: Marcel van der Veldt Date: Sun, 29 Nov 2020 15:42:16 +0100 Subject: [PATCH] bugfix: do not send stop on power off this is already ahandled in the player manager, accounting for grouped players etc --- music_assistant/constants.py | 2 +- music_assistant/providers/builtin_player/__init__.py | 1 - music_assistant/providers/chromecast/player.py | 1 - music_assistant/providers/sonos/sonos.py | 1 - music_assistant/providers/universal_group/__init__.py | 1 - 5 files changed, 1 insertion(+), 5 deletions(-) diff --git a/music_assistant/constants.py b/music_assistant/constants.py index 58cd102d..84b7cb00 100755 --- a/music_assistant/constants.py +++ b/music_assistant/constants.py @@ -1,6 +1,6 @@ """All constants for Music Assistant.""" -__version__ = "0.0.71" +__version__ = "0.0.72" REQUIRED_PYTHON_VER = "3.7" # configuration keys/attributes diff --git a/music_assistant/providers/builtin_player/__init__.py b/music_assistant/providers/builtin_player/__init__.py index dacc85fd..b9c7da17 100644 --- a/music_assistant/providers/builtin_player/__init__.py +++ b/music_assistant/providers/builtin_player/__init__.py @@ -233,7 +233,6 @@ class WebsocketsPlayer(Player): async def async_cmd_power_off(self) -> None: """Send POWER OFF command to player.""" - await self.async_cmd_stop() self._powered = False self.update_state() diff --git a/music_assistant/providers/chromecast/player.py b/music_assistant/providers/chromecast/player.py index d65f9707..d749e1a3 100644 --- a/music_assistant/providers/chromecast/player.py +++ b/music_assistant/providers/chromecast/player.py @@ -352,7 +352,6 @@ class ChromecastPlayer(Player): async def async_cmd_power_off(self) -> None: """Send power OFF command to player.""" - await self.async_cmd_stop() # chromecast has no real poweroff so we send mute instead await self.async_chromecast_command(self._chromecast.set_volume_muted, True) diff --git a/music_assistant/providers/sonos/sonos.py b/music_assistant/providers/sonos/sonos.py index e2b5bdd9..8d8603bd 100644 --- a/music_assistant/providers/sonos/sonos.py +++ b/music_assistant/providers/sonos/sonos.py @@ -155,7 +155,6 @@ class SonosProvider(PlayerProvider): player = self._players.get(player_id) if player: # power is not supported so abuse mute instead - self.mass.add_job(player.soco.stop) player.soco.mute = True player.powered = False else: diff --git a/music_assistant/providers/universal_group/__init__.py b/music_assistant/providers/universal_group/__init__.py index ff8d85fd..30960ea9 100644 --- a/music_assistant/providers/universal_group/__init__.py +++ b/music_assistant/providers/universal_group/__init__.py @@ -293,7 +293,6 @@ class GroupPlayer(Player): async def async_cmd_power_off(self) -> None: """Send POWER OFF command to player.""" - await self.async_cmd_stop() self._powered = False self.update_state() -- 2.34.1