From a8e0870267552570245a789eb6830700197aad42 Mon Sep 17 00:00:00 2001 From: Marcel van der Veldt Date: Wed, 26 Feb 2025 23:39:46 +0100 Subject: [PATCH] Fix: ignore volume in announcements when player does not support volume --- music_assistant/controllers/players.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/music_assistant/controllers/players.py b/music_assistant/controllers/players.py index a2162d62..61307ea0 100644 --- a/music_assistant/controllers/players.py +++ b/music_assistant/controllers/players.py @@ -1485,7 +1485,7 @@ class PlayerController(CoreController): player.volume_control = config.get_value(CONF_VOLUME_CONTROL) player.mute_control = config.get_value(CONF_MUTE_CONTROL) - async def _play_announcement( + async def _play_announcement( # noqa: PLR0915 self, player: Player, announcement: PlayerMedia, @@ -1552,7 +1552,9 @@ class PlayerController(CoreController): volume_player.display_name, ) tg.create_task(self.cmd_stop(volume_player.player_id)) - prev_volume = volume_player.volume_level + if volume_player.volume_control == PLAYER_CONTROL_NONE: + continue + prev_volume = volume_player.volume_level or 0 announcement_volume = self.get_announcement_volume(volume_player_id, volume_level) temp_volume = announcement_volume or player.volume_level if temp_volume != prev_volume: -- 2.34.1