From 9467898613ed0811da6773e40b82479605d12b8b Mon Sep 17 00:00:00 2001 From: Marcel van der Veldt Date: Fri, 14 Feb 2025 00:51:22 +0100 Subject: [PATCH] Chore: Add more logging to ffmpeg detection code --- music_assistant/helpers/ffmpeg.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/music_assistant/helpers/ffmpeg.py b/music_assistant/helpers/ffmpeg.py index d326e2e4..7c68baca 100644 --- a/music_assistant/helpers/ffmpeg.py +++ b/music_assistant/helpers/ffmpeg.py @@ -345,13 +345,19 @@ async def check_ffmpeg_version() -> None: "FFmpeg binary is missing from system. " "Please install ffmpeg on your OS to enable playback." ) + if returncode != 0: + raise AudioError( + "Error determining FFmpeg version on your system." + "Your CPU may be too old to run this version of FFmpeg." + f"Additional info: {returncode} {output.decode().strip()}" + ) # parse version number from output try: version = output.decode().split("ffmpeg version ")[1].split(" ")[0].split("-")[0] except IndexError: raise AudioError( "Error determining FFmpeg version on your system." - f"Additional info: {returncode} {output}" + f"Additional info: {returncode} {output.decode().strip()}" ) libsoxr_support = "enable-libsoxr" in output.decode() # use globals as in-memory cache -- 2.34.1