From 8b5b871b062b4ef3d96416eb687a3201911fcf79 Mon Sep 17 00:00:00 2001 From: Kieran Hogg Date: Wed, 26 Nov 2025 14:58:08 +0000 Subject: [PATCH] fix(bbc_sounds): Reorder menu API calls so only used by auth users (#2687) Rejig the order of menu API calls so we don't request it for unauthenticated users --- music_assistant/providers/bbc_sounds/__init__.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/music_assistant/providers/bbc_sounds/__init__.py b/music_assistant/providers/bbc_sounds/__init__.py index 2f91511b..6fe42f2f 100644 --- a/music_assistant/providers/bbc_sounds/__init__.py +++ b/music_assistant/providers/bbc_sounds/__init__.py @@ -212,7 +212,9 @@ class BBCSoundsProvider(MusicProvider): if not self.menu or ( isinstance(self.menu, Menu) and self.menu.sub_items and len(self.menu.sub_items) == 0 ): - await self._fetch_menu() + is_uk_listener = await self.client.auth.is_uk_listener + if self.client.auth.is_logged_in and is_uk_listener: + await self._fetch_menu() def _get_provider_mapping(self, item_id: str) -> ProviderMapping: return ProviderMapping( @@ -467,6 +469,8 @@ class BBCSoundsProvider(MusicProvider): async def _get_full_menu( self, path_parts: list[str] | None = None ) -> Sequence[MediaItemType | ItemMapping | BrowseFolder]: + if not self.menu: + await self._fetch_menu() if not self.menu or not self.menu.sub_items: raise MusicAssistantError("Menu API response is empty or invalid") menu_items = [] -- 2.34.1