From 790700ff791f2b06b3bb2a69e470a5f855ad50b9 Mon Sep 17 00:00:00 2001 From: Marcel van der Veldt Date: Mon, 22 Jan 2024 14:41:59 +0100 Subject: [PATCH] fix race conditions --- music_assistant/server/controllers/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/music_assistant/server/controllers/config.py b/music_assistant/server/controllers/config.py index 465e4e54..a4a66030 100644 --- a/music_assistant/server/controllers/config.py +++ b/music_assistant/server/controllers/config.py @@ -282,7 +282,7 @@ class ConfigController: await self.mass.music.cleanup_provider(instance_id) if existing["type"] == "player": # cleanup entries in player manager - for player in self.mass.players: + for player in list(self.mass.players): if player.provider != instance_id: continue self.mass.players.remove(player.player_id, cleanup_config=True) @@ -314,7 +314,7 @@ class ConfigController: available_providers = {x.domain for x in self.mass.providers} return [ await self.get_player_config(player_id) - for player_id, raw_conf in self.get(CONF_PLAYERS).items() + for player_id, raw_conf in self.get(CONF_PLAYERS, {}).items() # filter out unavailable providers if raw_conf["provider"] in available_providers # optional provider filter -- 2.34.1