From 642b2bae661e7acb8701e0bc0a6ff6e1c8bceb92 Mon Sep 17 00:00:00 2001 From: Marcel van der Veldt Date: Tue, 22 Oct 2024 18:00:35 +0200 Subject: [PATCH] Fix typo in sync players logic --- music_assistant/server/controllers/players.py | 2 +- music_assistant/server/providers/sonos/provider.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/music_assistant/server/controllers/players.py b/music_assistant/server/controllers/players.py index e937a65a..64c6ae77 100644 --- a/music_assistant/server/controllers/players.py +++ b/music_assistant/server/controllers/players.py @@ -685,7 +685,7 @@ class PlayerController(CoreController): # forward command to the player provider after all (base) sanity checks player_provider = self.get_player_provider(target_player) async with self._player_throttlers[target_player]: - await player_provider.cmd_sync_many(target_player, child_player_ids) + await player_provider.cmd_sync_many(target_player, final_player_ids) @api_command("players/cmd/unsync_many") async def cmd_unsync_many(self, player_ids: list[str]) -> None: diff --git a/music_assistant/server/providers/sonos/provider.py b/music_assistant/server/providers/sonos/provider.py index 1edf55e1..14facde2 100644 --- a/music_assistant/server/providers/sonos/provider.py +++ b/music_assistant/server/providers/sonos/provider.py @@ -188,8 +188,6 @@ class SonosPlayerProvider(PlayerProvider): async def cmd_sync_many(self, target_player: str, child_player_ids: list[str]) -> None: """Create temporary sync group by joining given players to target player.""" sonos_player = self.sonos_players[target_player] - # ensure we only send valid (and unique) player ids - child_player_ids = list({x for x in child_player_ids if x in self.sonos_players}) await sonos_player.client.player.group.modify_group_members( player_ids_to_add=child_player_ids, player_ids_to_remove=[] ) -- 2.34.1