From 3d905ba01a349901b116632e28cb1c4e39c2b446 Mon Sep 17 00:00:00 2001 From: Eric Munson Date: Sun, 4 May 2025 14:31:18 -0400 Subject: [PATCH] Subsonic: Fix: Only lookup album for track when an id exists (#2167) We are unconditionally looking up an album regardless of if one exists. Only do that work when we have an ID to lookup. Signed-off-by: Eric B Munson --- music_assistant/providers/opensubsonic/sonic_provider.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/music_assistant/providers/opensubsonic/sonic_provider.py b/music_assistant/providers/opensubsonic/sonic_provider.py index b61517d0..8afabe56 100644 --- a/music_assistant/providers/opensubsonic/sonic_provider.py +++ b/music_assistant/providers/opensubsonic/sonic_provider.py @@ -581,9 +581,11 @@ class OpenSonicProvider(MusicProvider): msg = f"Item {prov_track_id} not found" raise MediaNotFoundError(msg) from e aid = sonic_song.album_id if sonic_song.album_id else sonic_song.parent + album: Album | None = None if not aid: self.logger.warning("Unable to find album id for track %s", sonic_song.id) - album: Album = await self.get_album(prov_album_id=aid) + else: + album = await self.get_album(prov_album_id=aid) return self._parse_track(sonic_song, album=album) async def get_artist_albums(self, prov_artist_id: str) -> list[Album]: -- 2.34.1