From: Kostas Chatzikokolakis <kostas@chatzi.org>
Date: Sun, 27 Apr 2025 00:12:02 +0000 (+0300)
Subject: Add debug message about concatenating announcement stream (#2149)
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=c1ea73d571bd3ecfbdad92a4c7e77bedd9fac188;p=music-assistant-server.git

Add debug message about concatenating announcement stream (#2149)
---

diff --git a/music_assistant/controllers/streams.py b/music_assistant/controllers/streams.py
index 3bdb7541..ed6f5200 100644
--- a/music_assistant/controllers/streams.py
+++ b/music_assistant/controllers/streams.py
@@ -928,9 +928,9 @@ class StreamsController(CoreController):
             # For this to be effective the player itself needs to be able to start playback fast.
             # If the returned stream is used as input to ffmpeg we should pass -probesize 8096.
             #
-            # Finally we also need to make sure we don't make other blocking requests to the TTS
-            # data, eg to get the duration (async_parse_tags).
-            #
+            # Finally, if the output_format is non-PCM, raw concatenation can be problematic.
+            # So far players seem to tolerate this, but it might break some player in the future.
+
             async for chunk in get_ffmpeg_stream(
                 audio_input=ANNOUNCE_ALERT_FILE,
                 input_format=AudioFormat(content_type=ContentType.try_parse(ANNOUNCE_ALERT_FILE)),