From: Marcel van der Veldt <m.vanderveldt@outlook.com>
Date: Thu, 15 Jun 2023 16:54:18 +0000 (+0200)
Subject: race condition
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=bdcb0f4c83d7328adc37aa504745567db1de7b22;p=music-assistant-server.git

race condition
---

diff --git a/music_assistant/server/providers/slimproto/__init__.py b/music_assistant/server/providers/slimproto/__init__.py
index 5261d38b..a7cddde1 100644
--- a/music_assistant/server/providers/slimproto/__init__.py
+++ b/music_assistant/server/providers/slimproto/__init__.py
@@ -6,6 +6,7 @@ import statistics
 import time
 from collections import deque
 from collections.abc import Callable, Generator
+from contextlib import suppress
 from dataclasses import dataclass
 from typing import TYPE_CHECKING, Any
 
@@ -502,7 +503,8 @@ class SlimprotoProvider(PlayerProvider):
         if child_player.state == PlayerState.PLAYING:
             await self.cmd_stop(child_player.player_id)
         child_player.synced_to = None
-        parent_player.group_childs.remove(child_player.player_id)
+        with suppress(ValueError):
+            parent_player.group_childs.remove(child_player.player_id)
         self.mass.players.update(child_player.player_id)
         self.mass.players.update(parent_player.player_id)