From: OzGav <gavnosp@hotmail.com>
Date: Wed, 22 Oct 2025 08:29:48 +0000 (+1000)
Subject: Fix recursion loop in fake volume mute control (#2530)
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=bcbc7c579b3858c32a7307168075101546e4b7b1;p=music-assistant-server.git

Fix recursion loop in fake volume mute control (#2530)
---

diff --git a/music_assistant/controllers/players/player_controller.py b/music_assistant/controllers/players/player_controller.py
index 9bc803ba..e0a3753c 100644
--- a/music_assistant/controllers/players/player_controller.py
+++ b/music_assistant/controllers/players/player_controller.py
@@ -793,8 +793,8 @@ class PlayerController(CoreController):
                 player._attr_volume_muted = False
                 prev_volume = player.extra_data.get(ATTR_PREVIOUS_VOLUME, 1)
                 player.extra_data[ATTR_FAKE_MUTE] = False
-                await self.cmd_volume_set(player_id, prev_volume)
                 player.update_state()
+                await self.cmd_volume_set(player_id, prev_volume)
         else:
             # handle external player control
             player_control = self._controls.get(player.mute_control)