From: Marcel van der Veldt <m.vanderveldt@outlook.com>
Date: Wed, 26 Feb 2025 22:39:46 +0000 (+0100)
Subject: Fix: ignore volume in announcements when player does not support volume
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=a8e0870267552570245a789eb6830700197aad42;p=music-assistant-server.git

Fix: ignore volume in announcements when player does not support volume
---

diff --git a/music_assistant/controllers/players.py b/music_assistant/controllers/players.py
index a2162d62..61307ea0 100644
--- a/music_assistant/controllers/players.py
+++ b/music_assistant/controllers/players.py
@@ -1485,7 +1485,7 @@ class PlayerController(CoreController):
         player.volume_control = config.get_value(CONF_VOLUME_CONTROL)
         player.mute_control = config.get_value(CONF_MUTE_CONTROL)
 
-    async def _play_announcement(
+    async def _play_announcement(  # noqa: PLR0915
         self,
         player: Player,
         announcement: PlayerMedia,
@@ -1552,7 +1552,9 @@ class PlayerController(CoreController):
                         volume_player.display_name,
                     )
                     tg.create_task(self.cmd_stop(volume_player.player_id))
-                prev_volume = volume_player.volume_level
+                if volume_player.volume_control == PLAYER_CONTROL_NONE:
+                    continue
+                prev_volume = volume_player.volume_level or 0
                 announcement_volume = self.get_announcement_volume(volume_player_id, volume_level)
                 temp_volume = announcement_volume or player.volume_level
                 if temp_volume != prev_volume: