From: Marcel van der Veldt <m.vanderveldt@outlook.com>
Date: Sat, 22 Feb 2025 12:11:20 +0000 (+0100)
Subject: Chore: code quality changes
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=a60000d610ce44f04b5acc98e47ee8d41ec7988d;p=music-assistant-server.git

Chore: code quality changes
---

diff --git a/music_assistant/controllers/media/base.py b/music_assistant/controllers/media/base.py
index 5cd2ed07..95668f9f 100644
--- a/music_assistant/controllers/media/base.py
+++ b/music_assistant/controllers/media/base.py
@@ -809,16 +809,17 @@ class MediaControllerBase(Generic[ItemCls], metaclass=ABCMeta):
             db_row_dict["disc_number"] = track_album["disc_number"]
             db_row_dict["track_number"] = track_album["track_number"]
             # always prefer album image over track image
-            if images := track_album.get("images"):
-                album_thumb = next((x for x in images if x["type"] == "thumb"), None)
-                if album_thumb:
-                    # copy album image to itemmapping single image
-                    db_row_dict["image"] = album_thumb
-                    if db_row_dict["metadata"].get("images"):
-                        db_row_dict["metadata"]["images"] = [
-                            album_thumb,
-                            *db_row_dict["metadata"]["images"],
-                        ]
-                    else:
-                        db_row_dict["metadata"]["images"] = [album_thumb]
+            if (album_images := track_album.get("images")) and (
+                album_thumb := next((x for x in album_images if x["type"] == "thumb"), None)
+            ):
+                # copy album image to itemmapping single image
+                db_row_dict["image"] = album_thumb
+                if db_row_dict["metadata"].get("images"):
+                    # merge album image with existing images
+                    db_row_dict["metadata"]["images"] = [
+                        album_thumb,
+                        *db_row_dict["metadata"]["images"],
+                    ]
+                else:
+                    db_row_dict["metadata"]["images"] = [album_thumb]
         return db_row_dict