From: Maxim Raznatovski <nda.mr43@gmail.com>
Date: Thu, 11 Dec 2025 23:43:46 +0000 (+0100)
Subject: Fix changing of Sendspin over Cast settings (#2791)
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=9822d1a56352ad45262c95bde6e2a7b1734b8734;p=music-assistant-server.git

Fix changing of Sendspin over Cast settings (#2791)
---

diff --git a/music_assistant/providers/chromecast/constants.py b/music_assistant/providers/chromecast/constants.py
index c6dd0403..5ae91066 100644
--- a/music_assistant/providers/chromecast/constants.py
+++ b/music_assistant/providers/chromecast/constants.py
@@ -19,6 +19,8 @@ CONF_USE_MASS_APP = "use_mass_app"
 CONF_USE_SENDSPIN_MODE = "use_sendspin_mode"
 CONF_SENDSPIN_SYNC_DELAY = "sendspin_sync_delay"
 CONF_SENDSPIN_CODEC = "sendspin_codec"
+DEFAULT_SENDSPIN_SYNC_DELAY = -300
+DEFAULT_SENDSPIN_CODEC = "flac"
 
 CAST_PLAYER_CONFIG_ENTRIES = (
     CONF_ENTRY_OUTPUT_CODEC,
diff --git a/music_assistant/providers/chromecast/player.py b/music_assistant/providers/chromecast/player.py
index 252b7be2..82a931f4 100644
--- a/music_assistant/providers/chromecast/player.py
+++ b/music_assistant/providers/chromecast/player.py
@@ -43,6 +43,8 @@ from .constants import (
     CONF_SENDSPIN_SYNC_DELAY,
     CONF_USE_MASS_APP,
     CONF_USE_SENDSPIN_MODE,
+    DEFAULT_SENDSPIN_CODEC,
+    DEFAULT_SENDSPIN_SYNC_DELAY,
     MASS_APP_ID,
     SENDSPIN_CAST_APP_ID,
     SENDSPIN_CAST_NAMESPACE,
@@ -127,6 +129,7 @@ class ChromecastPlayer(Player):
         uuid_str = player_id.replace("-", "")
         self.sendspin_player_id = f"cast-{uuid_str[:8].lower()}"
         self._last_sent_sync_delay: int | None = None
+        self._last_sent_codec: str | None = None
 
         # Subscribe to sendspin player events for state syncing
         self._on_unload_callbacks.append(
@@ -219,7 +222,7 @@ class ChromecastPlayer(Player):
             # Check if sync delay config changed and resend if needed
             current_sync_delay = int(
                 self.mass.config.get_raw_player_config_value(
-                    self.player_id, CONF_SENDSPIN_SYNC_DELAY, -350
+                    self.player_id, CONF_SENDSPIN_SYNC_DELAY, DEFAULT_SENDSPIN_SYNC_DELAY
                 )
             )
             if self._last_sent_sync_delay != current_sync_delay:
@@ -262,7 +265,7 @@ class ChromecastPlayer(Player):
             "Positive values delay playback, negative values advance it. "
             "Use this to compensate for device-specific audio latency.",
             required=False,
-            default_value=-300,
+            default_value=DEFAULT_SENDSPIN_SYNC_DELAY,
             range=(-1000, 1000),
             hidden=not sendspin_available or self.type == PlayerType.GROUP,
         )
@@ -277,7 +280,7 @@ class ChromecastPlayer(Player):
             "Opus provides better compression but may have compatibility issues. "
             "PCM is uncompressed and uses more bandwidth.",
             required=False,
-            default_value="flac",
+            default_value=DEFAULT_SENDSPIN_CODEC,
             options=[
                 ConfigValueOption("FLAC (lossless, compressed)", "flac"),
                 ConfigValueOption("Opus (lossy, experimental)", "opus"),
@@ -302,6 +305,40 @@ class ChromecastPlayer(Player):
             sendspin_codec_config,
         ]
 
+    async def on_config_updated(self) -> None:
+        """Handle config updates - resend Sendspin config if needed."""
+        if not self.sendspin_mode_enabled:
+            return
+
+        # Get current config values
+        current_sync_delay = int(
+            self.mass.config.get_raw_player_config_value(
+                self.player_id, CONF_SENDSPIN_SYNC_DELAY, DEFAULT_SENDSPIN_SYNC_DELAY
+            )
+        )
+        current_codec = str(
+            self.mass.config.get_raw_player_config_value(
+                self.player_id, CONF_SENDSPIN_CODEC, DEFAULT_SENDSPIN_CODEC
+            )
+        )
+
+        # Resend if either value changed
+        if (
+            self._last_sent_sync_delay != current_sync_delay
+            or self._last_sent_codec != current_codec
+        ):
+            self.logger.debug(
+                "Sendspin config changed, resending (sync_delay: %s -> %s, codec: %s -> %s)",
+                self._last_sent_sync_delay,
+                current_sync_delay,
+                self._last_sent_codec,
+                current_codec,
+            )
+            try:
+                await self._send_sendspin_server_url()
+            except Exception as err:
+                self.logger.warning("Failed to send updated Sendspin config to Chromecast: %s", err)
+
     async def stop(self) -> None:
         """Send STOP command to given player."""
         if sendspin_player := self.get_linked_sendspin_player(True):
@@ -828,13 +865,13 @@ class ChromecastPlayer(Player):
         # Get sync delay from config (in milliseconds)
         sync_delay = int(
             self.mass.config.get_raw_player_config_value(
-                self.player_id, CONF_SENDSPIN_SYNC_DELAY, -350
+                self.player_id, CONF_SENDSPIN_SYNC_DELAY, DEFAULT_SENDSPIN_SYNC_DELAY
             )
         )
         # Get codec from config (default to flac)
         codec = str(
             self.mass.config.get_raw_player_config_value(
-                self.player_id, CONF_SENDSPIN_CODEC, "flac"
+                self.player_id, CONF_SENDSPIN_CODEC, DEFAULT_SENDSPIN_CODEC
             )
         )
         codecs = [codec]
@@ -861,6 +898,7 @@ class ChromecastPlayer(Player):
         )
         await self.mass.loop.run_in_executor(None, send_message)
         self._last_sent_sync_delay = sync_delay
+        self._last_sent_codec = codec
 
     async def _wait_for_sendspin_player(self, timeout: float = 15.0) -> Player | None:
         """Wait for the Sendspin player to connect and become available."""