From: Santiago Soto <santiago@soto.uy>
Date: Tue, 8 Apr 2025 20:03:23 +0000 (-0300)
Subject: fix: snapcast delete client (#2117)
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=6ad642cb1ece6fd875a21ecc4c1a93a7f512d12e;p=music-assistant-server.git

fix: snapcast delete client (#2117)

* Handle exceptions when removing a snapclient and log warnings

* Fix exception handling for snapclient removal to specifically catch TypeError
---

diff --git a/music_assistant/providers/snapcast/__init__.py b/music_assistant/providers/snapcast/__init__.py
index b1add931..a55fb304 100644
--- a/music_assistant/providers/snapcast/__init__.py
+++ b/music_assistant/providers/snapcast/__init__.py
@@ -446,7 +446,10 @@ class SnapCastProvider(PlayerProvider):
 
     async def remove_player(self, player_id: str) -> None:
         """Remove the client from the snapserver when it is deleted."""
-        await self._snapserver.delete_client(self._get_snapclient_id(player_id))
+        try:
+            await self._snapserver.delete_client(self._get_snapclient_id(player_id))
+        except TypeError as err:
+            self.logger.warning("Unable to remove snapclient %s: %s", player_id, str(err))
 
     async def cmd_volume_set(self, player_id: str, volume_level: int) -> None:
         """Send VOLUME_SET command to given player."""