From: Marcel van der Veldt <m.vanderveldt@outlook.com>
Date: Fri, 31 Oct 2025 02:25:25 +0000 (+0100)
Subject: Add note about get_ntp
X-Git-Url: https://git.kitaultman.com/?a=commitdiff_plain;h=51948c14aa95680e9b55212b63e104b6a2add36b;p=music-assistant-server.git

Add note about get_ntp
---

diff --git a/music_assistant/providers/airplay/protocols/_protocol.py b/music_assistant/providers/airplay/protocols/_protocol.py
index 52a5f7d1..11391226 100644
--- a/music_assistant/providers/airplay/protocols/_protocol.py
+++ b/music_assistant/providers/airplay/protocols/_protocol.py
@@ -83,6 +83,8 @@ class AirPlayProtocol(ABC):
     @abstractmethod
     async def get_ntp(self) -> int:
         """Get current NTP timestamp from the CLI binary."""
+        # this can probably be removed now that we already get the ntp
+        # in python (within the stream session start)
 
     @abstractmethod
     async def start(self, start_ntp: int, skip: int = 0) -> None:
diff --git a/music_assistant/providers/airplay/protocols/airplay2.py b/music_assistant/providers/airplay/protocols/airplay2.py
index 1e670702..59475632 100644
--- a/music_assistant/providers/airplay/protocols/airplay2.py
+++ b/music_assistant/providers/airplay/protocols/airplay2.py
@@ -35,7 +35,8 @@ class AirPlay2Stream(AirPlayProtocol):
 
     async def get_ntp(self) -> int:
         """Get current NTP timestamp."""
-        # TODO!
+        # this can probably be removed now that we already get the ntp
+        # in python (within the stream session start)
         return get_ntp_timestamp()
 
     @property
diff --git a/music_assistant/providers/airplay/protocols/raop.py b/music_assistant/providers/airplay/protocols/raop.py
index 805a6d22..1d994f9c 100644
--- a/music_assistant/providers/airplay/protocols/raop.py
+++ b/music_assistant/providers/airplay/protocols/raop.py
@@ -45,6 +45,8 @@ class RaopStream(AirPlayProtocol):
 
     async def get_ntp(self) -> int:
         """Get current NTP timestamp from the CLI binary."""
+        # this can probably be removed now that we already get the ntp
+        # in python (within the stream session start)
         cli_binary = await get_cli_binary(self.player.protocol)
         # TODO: we can potentially also just generate this ourselves?
         self.prov.logger.debug("Getting NTP timestamp from %s CLI binary", self.player.protocol)