Fix recursion loop in fake volume mute control (#2530)
authorOzGav <gavnosp@hotmail.com>
Wed, 22 Oct 2025 08:29:48 +0000 (18:29 +1000)
committerGitHub <noreply@github.com>
Wed, 22 Oct 2025 08:29:48 +0000 (10:29 +0200)
music_assistant/controllers/players/player_controller.py

index 9bc803ba816cb16cebcea75fa4888209329ad889..e0a3753c49ca8f3e5f9afa9026971b7cb275b1fb 100644 (file)
@@ -793,8 +793,8 @@ class PlayerController(CoreController):
                 player._attr_volume_muted = False
                 prev_volume = player.extra_data.get(ATTR_PREVIOUS_VOLUME, 1)
                 player.extra_data[ATTR_FAKE_MUTE] = False
-                await self.cmd_volume_set(player_id, prev_volume)
                 player.update_state()
+                await self.cmd_volume_set(player_id, prev_volume)
         else:
             # handle external player control
             player_control = self._controls.get(player.mute_control)