Fix: SMB provider on macos
authorMarcel van der Veldt <m.vanderveldt@outlook.com>
Wed, 8 Jan 2025 23:03:56 +0000 (00:03 +0100)
committerMarcel van der Veldt <m.vanderveldt@outlook.com>
Wed, 8 Jan 2025 23:03:56 +0000 (00:03 +0100)
music_assistant/providers/filesystem_smb/__init__.py

index a510876d4b008a570188c57abdc768f32fd9621d..b29b5b7121515dca99267263dddb90a244e1b055 100644 (file)
@@ -173,6 +173,11 @@ class SMBFileSystemProvider(LocalFileSystemProvider):
             if subfolder.endswith("/"):
                 subfolder = subfolder[:-1]
 
+        env_vars = {
+            **os.environ,
+            "USER": username,
+        }
+
         if platform.system() == "Darwin":
             # NOTE: MacOS does not support special characters in the username/password
             password_str = f":{password}" if password else ""
@@ -192,10 +197,6 @@ class SMBFileSystemProvider(LocalFileSystemProvider):
 
             # pass the username+password using (scoped) env variables
             # to prevent leaking in the process list and special chars supported
-            env_vars = {
-                **os.environ,
-                "USER": username,
-            }
             if password:
                 env_vars["PASSWD"] = str(password)