Fix typo in sync players logic
authorMarcel van der Veldt <m.vanderveldt@outlook.com>
Tue, 22 Oct 2024 16:00:35 +0000 (18:00 +0200)
committerMarcel van der Veldt <m.vanderveldt@outlook.com>
Tue, 22 Oct 2024 16:00:35 +0000 (18:00 +0200)
music_assistant/server/controllers/players.py
music_assistant/server/providers/sonos/provider.py

index e937a65a05470b573934ee738c2caa1976c777a9..64c6ae7728ba12beae710f7195427e2033a494b6 100644 (file)
@@ -685,7 +685,7 @@ class PlayerController(CoreController):
         # forward command to the player provider after all (base) sanity checks
         player_provider = self.get_player_provider(target_player)
         async with self._player_throttlers[target_player]:
-            await player_provider.cmd_sync_many(target_player, child_player_ids)
+            await player_provider.cmd_sync_many(target_player, final_player_ids)
 
     @api_command("players/cmd/unsync_many")
     async def cmd_unsync_many(self, player_ids: list[str]) -> None:
index 1edf55e1ce2f699bc6461b7ff626a2b77ac220d8..14facde255fb6f6a2168394a4acfec5b118af36a 100644 (file)
@@ -188,8 +188,6 @@ class SonosPlayerProvider(PlayerProvider):
     async def cmd_sync_many(self, target_player: str, child_player_ids: list[str]) -> None:
         """Create temporary sync group by joining given players to target player."""
         sonos_player = self.sonos_players[target_player]
-        # ensure we only send valid (and unique) player ids
-        child_player_ids = list({x for x in child_player_ids if x in self.sonos_players})
         await sonos_player.client.player.group.modify_group_members(
             player_ids_to_add=child_player_ids, player_ids_to_remove=[]
         )