Add note about get_ntp

diff --git a/music_assistant/providers/airplay/protocols/_protocol.py b/music_assistant/providers/airplay/protocols/_protocol.py
index 52a5f7d1f817f73afc806914ca612268f09728c7..113912263a9fac7e669de86dc1e92edf51a4fc51 100644 (file)
--- a/music_assistant/providers/airplay/protocols/_protocol.py
+++ b/music_assistant/providers/airplay/protocols/_protocol.py
@@ -83,6 +83,8 @@ class AirPlayProtocol(ABC):
     @abstractmethod
     async def get_ntp(self) -> int:
         """Get current NTP timestamp from the CLI binary."""
+        # this can probably be removed now that we already get the ntp
+        # in python (within the stream session start)
 
     @abstractmethod
     async def start(self, start_ntp: int, skip: int = 0) -> None:

diff --git a/music_assistant/providers/airplay/protocols/airplay2.py b/music_assistant/providers/airplay/protocols/airplay2.py
index 1e670702cf15e7e37b82a21e0287555fb1cbe06a..594756327b5879c8eda8807c59795b16d5d80076 100644 (file)
--- a/music_assistant/providers/airplay/protocols/airplay2.py
+++ b/music_assistant/providers/airplay/protocols/airplay2.py
@@ -35,7 +35,8 @@ class AirPlay2Stream(AirPlayProtocol):
 
     async def get_ntp(self) -> int:
         """Get current NTP timestamp."""
-        # TODO!
+        # this can probably be removed now that we already get the ntp
+        # in python (within the stream session start)
         return get_ntp_timestamp()
 
     @property

diff --git a/music_assistant/providers/airplay/protocols/raop.py b/music_assistant/providers/airplay/protocols/raop.py
index 805a6d22ab26ad869cbb2b877b284b94d85be6aa..1d994f9cd739bffe5d7cf902af2a91644778cfd9 100644 (file)
--- a/music_assistant/providers/airplay/protocols/raop.py
+++ b/music_assistant/providers/airplay/protocols/raop.py
@@ -45,6 +45,8 @@ class RaopStream(AirPlayProtocol):
 
     async def get_ntp(self) -> int:
         """Get current NTP timestamp from the CLI binary."""
+        # this can probably be removed now that we already get the ntp
+        # in python (within the stream session start)
         cli_binary = await get_cli_binary(self.player.protocol)
         # TODO: we can potentially also just generate this ourselves?
         self.prov.logger.debug("Getting NTP timestamp from %s CLI binary", self.player.protocol)