Fix adding tracks to playlists (#593)

* fix adding tracks to playlists

* fix leftover linting

diff --git a/music_assistant/server/controllers/media/playlists.py b/music_assistant/server/controllers/media/playlists.py
index c85eb881aedb4623fc1c6865b77982ce22fe12ae..379fd4de2234dca7bd5949b492c6a23c1cdeed66 100644 (file)
--- a/music_assistant/server/controllers/media/playlists.py
+++ b/music_assistant/server/controllers/media/playlists.py
@@ -120,7 +120,7 @@ class PlaylistController(MediaControllerBase[Playlist]):
         # grab all existing track ids in the playlist so we can check for duplicates
         cur_playlist_track_ids = set()
         count = 0
-        for item in await self.tracks(playlist_prov.item_id, playlist_prov.provider_domain):
+        async for item in self.tracks(playlist_prov.item_id, playlist_prov.provider_domain):
             count += 1
             cur_playlist_track_ids.update(
                 {

diff --git a/music_assistant/server/helpers/util.py b/music_assistant/server/helpers/util.py
index ac265e347905155bce2d4ca0ad99d6525959636f..3a6f3b18bca83480af940d025778a1ee58d2363c 100644 (file)
--- a/music_assistant/server/helpers/util.py
+++ b/music_assistant/server/helpers/util.py
@@ -4,12 +4,8 @@ from __future__ import annotations
 import asyncio
 import importlib
 import logging
-from collections.abc import AsyncGenerator, Iterator
-from contextlib import suppress
 from functools import lru_cache
-from typing import TYPE_CHECKING, Any
-
-from music_assistant.common.helpers.util import empty_queue
+from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from music_assistant.server.models import ProviderModuleType

diff --git a/music_assistant/server/providers/filesystem_smb/__init__.py b/music_assistant/server/providers/filesystem_smb/__init__.py
index 46970060b92be4c4101055bf34afec60fa9296ad..49297b6a01e9f14e6dc90c2b994a57151c8f9a3a 100644 (file)
--- a/music_assistant/server/providers/filesystem_smb/__init__.py
+++ b/music_assistant/server/providers/filesystem_smb/__init__.py
@@ -286,7 +286,6 @@ class SMBFileSystemProvider(FileSystemProviderBase):
                 task.cancel()
                 with suppress(asyncio.CancelledError):
                     await task
-            del queue
 
     async def write_file_content(self, file_path: str, data: bytes) -> None:
         """Write entire file content as bytes (e.g. for playlists)."""