Don't remove players on load in Home Assistant Player Provider (#2387)
authorMaxim Raznatovski <nda.mr43@gmail.com>
Tue, 9 Sep 2025 09:56:26 +0000 (11:56 +0200)
committerGitHub <noreply@github.com>
Tue, 9 Sep 2025 09:56:26 +0000 (11:56 +0200)
This is not required, since:
- Unloading a provider already unregisters all its players in `mass.py`s `unload_provider`
- Reloading a player provider first unloads the provider

music_assistant/providers/hass_players/provider.py

index a48f6dd68d3c85cdb7058601d80e4829c39de1c3..aa33ca091643413c9ed0bed75d24f0457b23c28e 100644 (file)
@@ -62,10 +62,6 @@ class HomeAssistantPlayerProvider(PlayerProvider):
         self.on_unload_callbacks = [
             await self.hass_prov.hass.subscribe_entities(self._on_entity_state_update, player_ids)
         ]
-        # remove any leftover players (after reconfigure of players)
-        for player in self.players:
-            if player.player_id not in player_ids:
-                self.mass.players.remove(player.player_id)
 
     async def unload(self, is_removed: bool = False) -> None:
         """