Fix: Subsonic: Don't recreate deleted bookmark (#2227)

Currently, when we delete a bookmark because the item is finished
playing, we continue on in the method and create a new bookmark for the
end of the item. What is supposed to happen is we delete the bookmark
and return. Log any deletion races and return when done.

Signed-off-by: Eric B Munson <eric@munsonfam.org>

diff --git a/music_assistant/providers/opensubsonic/sonic_provider.py b/music_assistant/providers/opensubsonic/sonic_provider.py
index bdff0adbb04b6bf2ab71774d1c6f719b46169a13..d4cef92a95f1ee132f50e1cc7ae004f5d065e7ca 100644 (file)
--- a/music_assistant/providers/opensubsonic/sonic_provider.py
+++ b/music_assistant/providers/opensubsonic/sonic_provider.py
@@ -671,13 +671,19 @@ class OpenSonicProvider(MusicProvider):
                 await self._run_async(self.conn.delete_bookmark, mid=ep_id)
             except DataNotFoundError:
                 # We probably raced with something else deleting this bookmark, not really a problem
-                return
+                self.logger.info("Bookmark for item '%s' has already been deleted.", ep_id)
+            return
 
         # Otherwise, create a new bookmark for this item or update the existing one
         # MA provides a position in seconds but expects it back in milliseconds, while
         # the Open Subsonic spec expects a position in milliseconds but returns it in
         # seconds, go figure.
-        await self._run_async(self.conn.create_bookmark, mid=ep_id, position=position * 1000)
+        await self._run_async(
+            self.conn.create_bookmark,
+            mid=ep_id,
+            position=position * 1000,
+            comment="Music Assistant Bookmark",
+        )
 
     async def get_resume_position(self, item_id: str, media_type: MediaType) -> tuple[bool, int]:
         """